Dodaje status 'spreman_za_zavrsetak' i backend provjeru koja blokira zatvaranje taska kada je povezani putni nalog otvoren, uz 409 odgovor i opcionalni auto-close flow.\n\nPri zatvaranju putnog naloga taskovi u statusu 'servis' automatski prelaze u 'spreman_za_zavrsetak'. Frontend modal sada podržava potvrdu i retry s auto_close_work_order=true.\n\nUključeni su i ciljani testovi za novi behavior, te ažuriran prikaz statusa u dashboardu.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
195 lines
8.5 KiB
Python
195 lines
8.5 KiB
Python
from django.test import TestCase
|
|
from django.contrib.auth import get_user_model
|
|
from rest_framework.exceptions import ValidationError
|
|
from modules.task_management.services import TaskService
|
|
from modules.task_management.exceptions import OpenWorkOrderBlockingTaskClose
|
|
from modules.task_management.models import Task, TaskTemplate, TaskTemplateEntry, TaskWorkEntry
|
|
from modules.fleet.models import Vehicle, WorkOrder, VehicleServiceRecord
|
|
|
|
|
|
class TaskServiceTests(TestCase):
|
|
def setUp(self):
|
|
User = get_user_model()
|
|
self.user = User.objects.create_user(username="user1", email="u1@example.test", password="pass")
|
|
self.other_user = User.objects.create_user(username="user2", email="u2@example.test", password="pass")
|
|
self.staff = User.objects.create_user(username="admin", email="admin@example.test", password="pass", is_staff=True)
|
|
|
|
def test_create_task_entry_creates_task_and_assigns_user(self):
|
|
data = {"title": "Do work", "description": "Something", "status": "aktivan"}
|
|
entry = TaskService.create_task_entry(data=data, user=self.user)
|
|
assert isinstance(entry, Task)
|
|
assert entry.assigned_to == self.user
|
|
assert entry.title == "Do work"
|
|
|
|
def test_create_task_entry_short_title_raises(self):
|
|
data = {"title": "x", "description": "", "status": "aktivan"}
|
|
with self.assertRaises(ValidationError):
|
|
TaskService.create_task_entry(data=data, user=self.user)
|
|
|
|
def test_update_task_entry_permission_denied_for_non_owner(self):
|
|
task = Task.objects.create(title="T", description="", assigned_to=self.other_user)
|
|
with self.assertRaises(ValidationError):
|
|
TaskService.update_task_entry(instance=task, data={"title": "New"}, user=self.user)
|
|
|
|
def test_update_task_entry_allowed_for_owner(self):
|
|
task = Task.objects.create(title="Old", description="", assigned_to=self.user)
|
|
updated = TaskService.update_task_entry(instance=task, data={"title": "New"}, user=self.user)
|
|
assert updated.title == "New"
|
|
|
|
def test_update_task_entry_rejects_closing_without_work_order(self):
|
|
task = Task.objects.create(title="Za zatvaranje", description="", assigned_to=self.user, status='servis')
|
|
with self.assertRaises(ValidationError):
|
|
TaskService.update_task_entry(instance=task, data={"status": "neaktivan"}, user=self.user)
|
|
|
|
def test_update_task_entry_allows_closing_with_work_order(self):
|
|
vehicle = Vehicle.objects.create(registration_number="ZG-TASK-01", asset_type='crane')
|
|
work_order = WorkOrder.objects.create(
|
|
vehicle=vehicle,
|
|
creator=self.user,
|
|
purpose='defektaza',
|
|
status='closed',
|
|
start_mileage=100,
|
|
end_mileage=120,
|
|
)
|
|
task = Task.objects.create(title="Za zatvaranje", description="", assigned_to=self.user, status='servis')
|
|
updated = TaskService.update_task_entry(
|
|
instance=task,
|
|
data={"status": "neaktivan", "work_order": work_order},
|
|
user=self.user,
|
|
)
|
|
assert updated.status == "neaktivan"
|
|
assert updated.work_order == work_order
|
|
|
|
def test_update_task_entry_rejects_finished_without_work_order(self):
|
|
task = Task.objects.create(title="Za završetak", description="", assigned_to=self.user, status='servis')
|
|
with self.assertRaises(ValidationError):
|
|
TaskService.update_task_entry(instance=task, data={"status": "zavrsen"}, user=self.user)
|
|
|
|
def test_update_task_entry_allows_finished_with_work_order(self):
|
|
vehicle = Vehicle.objects.create(registration_number="ZG-TASK-01A", asset_type='crane')
|
|
work_order = WorkOrder.objects.create(
|
|
vehicle=vehicle,
|
|
creator=self.user,
|
|
purpose='kontrola',
|
|
status='closed',
|
|
start_mileage=100,
|
|
end_mileage=150,
|
|
)
|
|
task = Task.objects.create(title="Za završetak", description="", assigned_to=self.user, status='servis', vehicle=vehicle)
|
|
updated = TaskService.update_task_entry(
|
|
instance=task,
|
|
data={"status": "zavrsen", "work_order": work_order},
|
|
user=self.user,
|
|
)
|
|
assert updated.status == "zavrsen"
|
|
assert updated.work_order == work_order
|
|
|
|
def test_update_task_entry_blocks_closing_when_work_order_open(self):
|
|
vehicle = Vehicle.objects.create(registration_number="ZG-TASK-01B", asset_type='crane')
|
|
work_order = WorkOrder.objects.create(vehicle=vehicle, creator=self.user, purpose='kontrola', status='open')
|
|
task = Task.objects.create(
|
|
title="Integritet",
|
|
description="",
|
|
assigned_to=self.user,
|
|
status='servis',
|
|
vehicle=vehicle,
|
|
work_order=work_order,
|
|
)
|
|
|
|
with self.assertRaises(OpenWorkOrderBlockingTaskClose):
|
|
TaskService.update_task_entry(
|
|
instance=task,
|
|
data={"status": "zavrsen"},
|
|
user=self.user,
|
|
)
|
|
|
|
def test_update_task_entry_can_auto_close_open_work_order(self):
|
|
vehicle = Vehicle.objects.create(registration_number="ZG-TASK-01C", asset_type='crane')
|
|
work_order = WorkOrder.objects.create(
|
|
vehicle=vehicle,
|
|
creator=self.user,
|
|
purpose='kontrola',
|
|
status='open',
|
|
start_mileage=100,
|
|
end_mileage=150,
|
|
)
|
|
task = Task.objects.create(
|
|
title="Auto close",
|
|
description="",
|
|
assigned_to=self.user,
|
|
status='servis',
|
|
vehicle=vehicle,
|
|
work_order=work_order,
|
|
)
|
|
updated = TaskService.update_task_entry(
|
|
instance=task,
|
|
data={"status": "zavrsen"},
|
|
user=self.user,
|
|
auto_close_work_order=True,
|
|
)
|
|
work_order.refresh_from_db()
|
|
self.assertEqual(updated.status, "zavrsen")
|
|
self.assertEqual(work_order.status, "closed")
|
|
|
|
def test_create_task_entry_from_template_creates_service_records(self):
|
|
vehicle = Vehicle.objects.create(registration_number="ZG-TASK-02", asset_type='crane')
|
|
template = TaskTemplate.objects.create(
|
|
code='template-servis-zapisi',
|
|
title='Template servis',
|
|
description='Opis templatea',
|
|
status='aktivan',
|
|
)
|
|
TaskTemplateEntry.objects.create(
|
|
task_template=template,
|
|
sort_order=1,
|
|
title='Pregled sustava',
|
|
work_description='Provjera hidraulike',
|
|
active_faults='Greška E101',
|
|
explanation_hr='Prevedeno i objašnjeno.',
|
|
)
|
|
TaskTemplateEntry.objects.create(
|
|
task_template=template,
|
|
sort_order=2,
|
|
title='Zamjena senzora',
|
|
work_description='Zamijenjen senzor kuta',
|
|
active_faults='',
|
|
explanation_hr='Senzor kalibriran.',
|
|
)
|
|
|
|
created = TaskService.create_task_entry(
|
|
data={'template_id': template.id, 'vehicle': vehicle},
|
|
user=self.user,
|
|
)
|
|
|
|
self.assertEqual(created.vehicle_id, vehicle.id)
|
|
self.assertEqual(TaskWorkEntry.objects.filter(task=created).count(), 2)
|
|
records = VehicleServiceRecord.objects.filter(task=created).order_by('created_at')
|
|
self.assertEqual(records.count(), 2)
|
|
self.assertEqual(records.first().service_title, 'Pregled sustava')
|
|
self.assertIn('Obrazloženje (HR): Prevedeno i objašnjeno.', records.first().description)
|
|
self.assertIn('Aktivne greške: Greška E101', records.first().description)
|
|
self.assertEqual(records.first().performed_by_id, self.user.id)
|
|
|
|
def test_create_task_entry_from_template_limits_service_records_to_ten(self):
|
|
vehicle = Vehicle.objects.create(registration_number="ZG-TASK-03", asset_type='crane')
|
|
template = TaskTemplate.objects.create(
|
|
code='template-limit-10',
|
|
title='Template limit',
|
|
description='Opis',
|
|
status='aktivan',
|
|
)
|
|
for index in range(1, 13):
|
|
TaskTemplateEntry.objects.create(
|
|
task_template=template,
|
|
sort_order=index,
|
|
title=f'Korak {index}',
|
|
work_description=f'Opis {index}',
|
|
)
|
|
|
|
created = TaskService.create_task_entry(
|
|
data={'template_id': template.id, 'vehicle': vehicle},
|
|
user=self.user,
|
|
)
|
|
|
|
self.assertEqual(TaskWorkEntry.objects.filter(task=created).count(), 10)
|
|
self.assertEqual(VehicleServiceRecord.objects.filter(task=created).count(), 10) |